Skip to content

chore(checkbox): add e2e test for spacebar checking #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2016

Conversation

devversion
Copy link
Member

  • Adds the missing e2e test for the checkbox, where the space key should toggle the state
  • Cleanup the existing e2e test by removing repeating statements

* Adds the missing e2e test for the checkbox, where the space key should toggle the state
* Cleanup the existing e2e test by removing repeating statements
@devversion devversion requested a review from jelbourn December 24, 2016 14:35
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 24, 2016
@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 28, 2016
@jelbourn jelbourn merged commit 3230c33 into angular:master Dec 28, 2016
@devversion devversion deleted the chore/checkbox-space-e2e branch December 28, 2016 08:55
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants