Skip to content

docs(material/autocomplete): change documentation for the optionActivated event #24844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2022
Merged

docs(material/autocomplete): change documentation for the optionActivated event #24844

merged 1 commit into from
Apr 28, 2022

Conversation

ddubrava
Copy link
Contributor

@ddubrava ddubrava commented Apr 28, 2022 •
edited
Loading

Hi! I removed 'using the keyabord' since it's not correct.
btw, I'm not sure the current description is accurate enough. Perhaps we should include some information about the active index logic.

Fixes #24799

@ddubrava ddubrava requested a review from crisbeto as a code owner April 28, 2022 09:56
crisbeto
crisbeto approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Apr 28, 2022
@andrewseguin andrewseguin merged commit 6266270 into angular:master Apr 28, 2022
andrewseguin pushed a commit that referenced this pull request Apr 28, 2022
@ddubrava @andrewseguin
docs(material/autocomplete): change documentation for the optionActiv…
5956ef3 
…ated event (#24844)

Fixes #24799

(cherry picked from commit 6266270)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs-bug(Autocomplete): Documentation for (optionActivated) incorrect.
3 participants
@ddubrava @crisbeto @andrewseguin