refactor(cdk/drag-drop): move sorting and positioning logic into a separate class #25044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parate class This is an internal reorganization of the drop list to make it easier to eventually add support for mixed orientation. Includes: * Moving out all the sorting and positioning-related code out of `DropListRef` and into a separate class. The existing logic is very specific to our approach that moves items around using `transform`. The future mixed orientation will likely move the DOM nodes themselves which would've been difficult to manage if we kept the positioning logic within `DropListRef`. * Moves some of the DOM-related utilities into the `dom` directory in order to reduce clutter in the root of the package.
crisbeto
added
P3
devversion
approved these changes
Jun 9, 2022
crisbeto
added a commit
that referenced
this pull request
Jun 9, 2022
…parate class (#25044) This is an internal reorganization of the drop list to make it easier to eventually add support for mixed orientation. Includes: * Moving out all the sorting and positioning-related code out of `DropListRef` and into a separate class. The existing logic is very specific to our approach that moves items around using `transform`. The future mixed orientation will likely move the DOM nodes themselves which would've been difficult to manage if we kept the positioning logic within `DropListRef`. * Moves some of the DOM-related utilities into the `dom` directory in order to reduce clutter in the root of the package. (cherry picked from commit d40da65)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an internal reorganization of the drop list to make it easier to eventually add support for mixed orientation. Includes:
DropListRefand into a separate class. The existing logic is very specific to our approach that moves items around usingtransform. The future mixed orientation will likely move the DOM nodes themselves which would've been difficult to manage if we kept the positioning logic withinDropListRef.domdirectory in order to reduce clutter in the root of the package.