-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: update angular shared dev-infra code to fed4403 #25187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
devversion
merged 2 commits into
angular:main
from
angular-robot:ng-renovate/angular-shared-dev-infra-code
Jul 4, 2022
Merged
build: update angular shared dev-infra code to fed4403 #25187
devversion
merged 2 commits into
angular:main
from
angular-robot:ng-renovate/angular-shared-dev-infra-code
Jul 4, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ce4c0c
to
ac236e5
Compare
ac236e5
to
36c3c9a
Compare
36c3c9a
to
b2b30ad
Compare
b2b30ad
to
6485f28
Compare
6485f28
to
6f45fe9
Compare
1a19542
to
8753b58
Compare
e056217
to
ff68e45
Compare
ff68e45
to
b6fc6a0
Compare
b6fc6a0
to
fd324b5
Compare
fd324b5
to
8f0237c
Compare
39f97ef
to
08e7f68
Compare
08e7f68
to
6a42d9d
Compare
The Angular CLI requires the `node_modules` directory for ngcc to be present. With PnP this directory does not exist and we need to make sure it exists. Previously it worked without the explicit command because it went up the execroot, but the CLI made this stricter so that we now notice it until the fix/looser check is available: angular/angular-cli@5319428.
6a42d9d
to
f21a665
Compare
devversion
approved these changes
Jul 4, 2022
devversion
added a commit
that referenced
this pull request
Jul 4, 2022
* build: update angular shared dev-infra code to fed4403 * test: create `node_modules` directory in PnP integration test The Angular CLI requires the `node_modules` directory for ngcc to be present. With PnP this directory does not exist and we need to make sure it exists. Previously it worked without the explicit command because it went up the execroot, but the CLI made this stricter so that we now notice it until the fix/looser check is available: angular/angular-cli@5319428. Co-authored-by: Paul Gschwendtner <[email protected]> (cherry picked from commit 2b53d7b)
devversion
added a commit
that referenced
this pull request
Jul 4, 2022
* build: update angular shared dev-infra code to fed4403 * test: create `node_modules` directory in PnP integration test The Angular CLI requires the `node_modules` directory for ngcc to be present. With PnP this directory does not exist and we need to make sure it exists. Previously it worked without the explicit command because it went up the execroot, but the CLI made this stricter so that we now notice it until the fix/looser check is available: angular/angular-cli@5319428. Co-authored-by: Paul Gschwendtner <[email protected]> (cherry picked from commit 2b53d7b)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
67631cd
->fed4403
f5e706a
->b5e4e32
🔡 If you wish to disable git hash updates, add
":disableDigestUpdates"
to the extends array in your config.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.