Skip to content

build: fix dev-app preview action permissions #25206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

We have changed the default permissions for Github actions as it seems,
and the PR comment cannot be created in actions without having the
necessary write permission. This commit fixes this.

@devversion devversion requested a review from crisbeto July 1, 2022 12:49
@devversion devversion requested a review from a team as a code owner July 1, 2022 12:49
@devversion devversion self-assigned this Jul 1, 2022
We have changed the default permissions for Github actions as it seems,
and the PR comment cannot be created in actions without having the
necessary write permission. This commit fixes this.
@devversion devversion force-pushed the fix-dev-app-preview-permissions branch from d1e92ae to 2dafe01 Compare July 1, 2022 13:19
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Jul 1, 2022
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jul 1, 2022
@devversion devversion merged commit f66e7ad into angular:main Jul 1, 2022
devversion added a commit that referenced this pull request Jul 1, 2022
We have changed the default permissions for Github actions as it seems,
and the PR comment cannot be created in actions without having the
necessary write permission. This commit fixes this.

(cherry picked from commit f66e7ad)
devversion added a commit that referenced this pull request Jul 1, 2022
We have changed the default permissions for Github actions as it seems,
and the PR comment cannot be created in actions without having the
necessary write permission. This commit fixes this.

(cherry picked from commit f66e7ad)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants