Skip to content

build: update angular shared dev-infra code to fed4403 #25223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

devversion
Copy link
Member

@devversion devversion commented Jul 4, 2022

Fixed-up version of #25187

angular-robot and others added 2 commits July 4, 2022 12:00
The Angular CLI requires the `node_modules` directory for ngcc to be
present. With PnP this directory does not exist and we need to make sure
it exists. Previously it worked without the explicit command because it
went up the execroot, but the CLI made this stricter so that we now
notice it until the fix/looser check is available:

angular/angular-cli@5319428.
@devversion devversion requested review from a team and andrewseguin as code owners July 4, 2022 12:51
@devversion devversion added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Jul 4, 2022
@devversion devversion closed this Jul 4, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants