Skip to content

refactor(material/snack-bar): fix out-of-sync code #25302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

crisbeto
Copy link
Member

Fixes some code that is out of sync with the code we have internally. I added the extra @if when I was resolving issues with #25273.

Fixes some code that is out of sync with the code we have internally. I added the extra `@if` when I was resolving issues with angular#25273.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: minor This PR is targeted for the next minor release labels Jul 19, 2022
@crisbeto crisbeto requested a review from devversion July 19, 2022 07:33
@crisbeto crisbeto requested a review from andrewseguin as a code owner July 19, 2022 07:33
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to bring this in sync. OOC: Is this expected though? The individual theming system functions should not be invoked with null, guarded by the theme mixins checking for null

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 19, 2022
@crisbeto
Copy link
Member Author

This came up during the presubmit where some apps were ending up with a partial/non-existent typography config. I did it this way to maintain backwards compatibility.

@crisbeto crisbeto merged commit d665625 into angular:main Jul 19, 2022
@devversion
Copy link
Member

Sounds reasonable. Generally this is unexpected though and we shouldn't need these checks elsewhere, except for e.g. backwards compatibility here (in which case we may want to clean this up in the future I think)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants