-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(cdk-experimental/listbox): add docs & examples #25317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deployed dev-app to: https://ng-comp-dev--pr-25317-12d13d41740a198e4dbe0775a21877e3-s5kwevwm.web.app |
I embedded all the examples I added in the dev-app, you can check them out here: https://ng-comp-dev--pr-25317-2998a6aea0f4c5d81c00616767c9e8e1-rzze2wbv.web.app/cdk-experimental-listbox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only skimmed looking over the code, but I did test this with voiceover on chrome. Here's what I found.
The checkmark unicode character should aria-hidden="true"
because it is decorative. Otherwise screen readers will actually try to read the checkmark. Probably fine to not put aria-hidden="true" on the emojis.
The listbox spec has an optional requirement where pressing Home and End moves focus to the start or end of the listbox. Not required, but it's an improvement if you're looking for something. https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/listbox_role
ok, its on a
are you saying that the sceenreader is reading "Syrah" as selected, or that it looks selected? The background color was supposed to indicate focused-ness but I was applying it based on the active class which remains if the entire listbox is defocused. I've switched it to target
are you saying those keys don't work for you? they seem to be working for me |
Home/End are not working correctly when I have VoiceOver turned on. This only aplys to the examples "Listbox with Value Binding", "Listbox with compareWith Function", "Listbox with Reactive Forms", "Listbox with Forms Validation", "Listbox with Disabled Options", "Horizontal Listbox", "Listbox with Custom Typeahead", and "Listbox with Custom Keyboard Navigation Options". However, it works fine when voiceover is turned off. Yes voiceover is reading Syrah as selected when I navigate to it via the down arrow. When I navigate via screen reader navigation (cmd + option + down), Voice Over reads Syrah, but not as selected. |
cdk-listbox-voiceover.mov
Looks like the listbox focuses the correct item when I press End with VoiceOver enabled, but the screen reader's navigation state gets in a bad state. |
@zarend I definitely want to look into the strange a11y behavior you're seeing, but I'll do it in a followup PR |
* docs(cdk-experimental/listbox): add docs & examples * fixup! docs(cdk-experimental/listbox): add docs & examples * fixup! docs(cdk-experimental/listbox): add docs & examples
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.