Skip to content

Switch form field and select examples to MDC #25374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 2, 2022

Tests out switching the docs examples over to MDC by migrating the ones for mat-form-field and mat-select. I had to fix up a few visual issues and update some text in the guide for mat-form-field.

@crisbeto crisbeto force-pushed the migration-docs-test branch from d4e8040 to 1ea1813 Compare August 2, 2022 07:44
Switches the form field examples to use the MDC implementation of the form field and fixes some visual issues that came up as a result.
Switches the select examples to use MDC and fixes a minor visual issue.
@crisbeto crisbeto force-pushed the migration-docs-test branch from 1ea1813 to 50c3a4c Compare August 2, 2022 07:49
@crisbeto crisbeto marked this pull request as ready for review August 2, 2022 07:54
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Aug 2, 2022
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge safe labels Aug 2, 2022
@crisbeto crisbeto merged commit 7acbf1f into angular:main Aug 2, 2022
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 21, 2022
Restores the docs examples for the legacy `matInput` which were deleted in angular#25374.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 21, 2022
Restores the docs examples for the legacy `mat-form-field` which were deleted in angular#25374.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 21, 2022
Restores the docs examples for the legacy `mat-form-field` which were deleted in angular#25374.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants