Skip to content

build: fix select e2e tests #25375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 2, 2022

In a previous PR I assumed that a timeout in the select e2e tests was a flake, but it was actually a failure, because the test is running against the docs examples which were switched over to MDC.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: major This PR is targeted for the next major release labels Aug 2, 2022
@crisbeto crisbeto requested a review from devversion August 2, 2022 08:40
In a previous PR I assumed that a timeout in the select e2e tests was a flake, but it was actually a failure, because the test is running against the docs examples which were switched over to MDC.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 2, 2022
@crisbeto crisbeto merged commit ca53bb5 into angular:main Aug 2, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants