Skip to content

build: fix snapshot tests failure #25388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 3, 2022

Fixes the build error in the snapshots check by applying a similar fix to #25303.

@crisbeto crisbeto added merge safe target: major This PR is targeted for the next major release labels Aug 3, 2022
@crisbeto crisbeto requested a review from wagnermaciel August 3, 2022 16:48
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Fixes the build error in the snapshots check by applying a similar fix to angular#25303.
@crisbeto crisbeto force-pushed the schematics-build-again branch from 63ac93c to 258b62a Compare August 3, 2022 16:52
@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Aug 3, 2022
@wagnermaciel wagnermaciel merged commit 301dbf7 into angular:main Aug 3, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants