fix(cdk/dialog): fall back to node injector token doesn't exist in template injector #25406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
|
Keen! 🙏 |
…mplate injector In angular#24570 the template dialog was changed so that the dialog ref is resolved from the template injector, rather than the DOM. The problem is that existing logic for constructing the injector was reused which means that the lookup path for a token starting from inside the `ng-template` would be `start -> node injector -> template injector -> app injector` instead of `start -> node injector -> template injector -> node injector -> app injector`. This has caused some regressions for users of `@angular/router` like angular/angular#46500. These changes resolve the issue by not providing a fallback injector so that the framework automatically falls back to the node injector.
crisbeto
force-pushed
the
template-dialog-injector
branch
from
1082bf0 to
03f2f5b
Compare
crisbeto
added a commit
that referenced
this pull request
Aug 15, 2022
…mplate injector (#25406) In #24570 the template dialog was changed so that the dialog ref is resolved from the template injector, rather than the DOM. The problem is that existing logic for constructing the injector was reused which means that the lookup path for a token starting from inside the `ng-template` would be `start -> node injector -> template injector -> app injector` instead of `start -> node injector -> template injector -> node injector -> app injector`. This has caused some regressions for users of `@angular/router` like angular/angular#46500. These changes resolve the issue by not providing a fallback injector so that the framework automatically falls back to the node injector. (cherry picked from commit 8027b5b)
crisbeto
added a commit
that referenced
this pull request
Aug 15, 2022
…mplate injector (#25406) In #24570 the template dialog was changed so that the dialog ref is resolved from the template injector, rather than the DOM. The problem is that existing logic for constructing the injector was reused which means that the lookup path for a token starting from inside the `ng-template` would be `start -> node injector -> template injector -> app injector` instead of `start -> node injector -> template injector -> node injector -> app injector`. This has caused some regressions for users of `@angular/router` like angular/angular#46500. These changes resolve the issue by not providing a fallback injector so that the framework automatically falls back to the node injector. (cherry picked from commit 8027b5b)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Aug 23, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.1.2` -> `14.1.3`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.1.2/14.1.3) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.1.2` -> `14.1.3`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.1.2/14.1.3) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v14.1.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1413-rubber-chicken-2022-08-19) [Compare Source](angular/components@14.1.2...14.1.3) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [f661a9300e](angular/components@f661a93) | fix | **dialog:** fall back to node injector token doesn't exist in template injector ([#​25406](angular/components#25406)) | | [b9f09aa741](angular/components@b9f09aa) | fix | **overlay:** backdropClass type mismatch ([#​25487](angular/components#25487)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [d1ef7e23c6](angular/components@d1ef7e2) | fix | **button-toggle:** toggle name falling out of sync if name changes ([#​24713](angular/components#24713)) | | [19df7cf940](angular/components@19df7cf) | fix | **expansion:** fix lint issue ([#​25469](angular/components#25469)) | ##### expansion | Commit | Type | Description | | -- | -- | -- | | [b1450b1cb5](angular/components@b1450b1) | fix | fix expansion `.mat-expansion-panel-header` styles ([#​20019](angular/components#20019)) | #### Special Thanks Andrew Seguin, Dmitrii Kuzmin, Kristiyan Kostadinov, ko-tori and swseverance <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNjUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE2NS4xIn0=--> Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1515 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
This was referenced Aug 23, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #24570 the template dialog was changed so that the dialog ref is resolved from the template injector, rather than the DOM. The problem is that existing logic for constructing the injector was reused which means that the lookup path for a token starting from inside the
ng-templatewould bestart -> node injector -> template injector -> app injectorinstead ofstart -> node injector -> template injector -> node injector -> app injector. This has caused some regressions for users of@angular/routerlike angular/angular#46500.These changes resolve the issue by not providing a fallback injector so that the framework automatically falls back to the node injector.