test(cdk/testing): add includeAsyncTests flag #25542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed by some downstream custom angular harnesses that use this set of tests but also do not rely on Angular framework stabilization.
|
How are these tests used by the downstream custom Angular harnesses? I don't think we ship these to NPM |
mmalerba
reviewed
Aug 26, 2022
|
@devversion we're copybara-ing this into google3, so its used there |
mmalerba
added
action: merge
|
Ahh, I was on a personal device and didn't know this being for a Google use-case. SGTM |
devversion
approved these changes
Aug 26, 2022
mmalerba
pushed a commit
that referenced
this pull request
Aug 29, 2022
* test(cdk/testing): add includeAsyncTests flag This is needed by some downstream custom angular harnesses that use this set of tests but also do not rely on Angular framework stabilization. * test(cdk/testing): rework `includeAsyncTests` into `skipAsyncTests` * test(cdk/testing): fix stale param doc (cherry picked from commit 7faafb4)
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Sep 16, 2022
* test(cdk/testing): add includeAsyncTests flag This is needed by some downstream custom angular harnesses that use this set of tests but also do not rely on Angular framework stabilization. * test(cdk/testing): rework `includeAsyncTests` into `skipAsyncTests` * test(cdk/testing): fix stale param doc
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed by some downstream custom angular harnesses that use this set of tests but also do not rely on Angular framework stabilization.