Skip to content

test(cdk/testing): Allow TestComponentsModule to be bootable as a mod… #25561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

mgoldberg524
Copy link
Contributor

…ule for a standalone app

This is required by downstream tests that use the cross-environment tests but do not start up the entire e2e test app in this repo. This change will be copybara'ed down to google3.

…ule for a standalone app

This is required by downstream tests that use the cross-environment tests but do not start up the entire e2e test app in this repo. This change will be copybara'ed down to google3
@mgoldberg524 mgoldberg524 marked this pull request as ready for review August 31, 2022 17:52
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added target: patch This PR is targeted for the next patch release merge safe action: merge The PR is ready for merge by the caretaker labels Aug 31, 2022
@crisbeto
Copy link
Member

crisbeto commented Sep 1, 2022

It looks like these changes were merged internally already. Merging this PR so that we're in sync.

@crisbeto crisbeto merged commit 0ad5d60 into angular:main Sep 1, 2022
crisbeto pushed a commit that referenced this pull request Sep 1, 2022
…ule for a standalone app (#25561)

This is required by downstream tests that use the cross-environment tests but do not start up the entire e2e test app in this repo. This change will be copybara'ed down to google3

(cherry picked from commit 0ad5d60)
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Sep 16, 2022
…ule for a standalone app (angular#25561)

This is required by downstream tests that use the cross-environment tests but do not start up the entire e2e test app in this repo. This change will be copybara'ed down to google3
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants