Skip to content

fix(material/core): warn when legacy theme is created #25625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 12, 2022
Merged

fix(material/core): warn when legacy theme is created #25625

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
69494a1
fix(material/core): warn when legacy theme is created
andrewseguin Sep 12, 2022
0d53d53
fix(material/core): update message
andrewseguin Sep 12, 2022
e030371
fix(material/core): update message
andrewseguin Sep 12, 2022
098832c
fix(material/core): update message
andrewseguin Sep 12, 2022
e8a55c5
fix(material/core): update message
andrewseguin Sep 12, 2022
105cf44
fix(material/core): update message
andrewseguin Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/material/core/theming/_theming.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ $_generate-default-density: true !default;
$_duplicate-warning: 'Read more about how style duplication can be avoided in a dedicated ' +
'guide. https://github.com/angular/components/blob/main/guides/duplicate-theming-styles.md';

// Warning that will be printed if the legacy theming API is used.
$_legacy-theme-warning: 'Angular Material themes should be created from a map containing the ' +
'keys "color", "typography", and "density". The color value should be a map containing the ' +
'palette values for "primary", "accent", and "warn". ' +
'See https://material.angular.io/guide/theming for more information.';

// These variable are not intended to be overridden externally. They use `!default` to
// avoid being reset every time this file is imported.
$_emitted-color: () !default;
Expand Down Expand Up @@ -167,6 +173,7 @@ $_emitted-density: () !default;
// If the legacy pattern is used, we generate a container object only with a light-themed
// configuration for the `color` theming part.
@if $accent != null {
@warn $_legacy-theme-warning;
@return private-create-backwards-compatibility-theme(_mat-validate-theme((
_is-legacy-theme: true,
color: _mat-create-light-color-config($primary, $accent, $warn),
Expand Down Expand Up @@ -207,6 +214,7 @@ $_emitted-density: () !default;
// If the legacy pattern is used, we generate a container object only with a dark-themed
// configuration for the `color` theming part.
@if $accent != null {
@warn $_legacy-theme-warning;
@return private-create-backwards-compatibility-theme(_mat-validate-theme((
_is-legacy-theme: true,
color: _mat-create-dark-color-config($primary, $accent, $warn),
Expand Down Expand Up @@ -432,6 +440,8 @@ $_emitted-density: () !default;
@if private-is-theme-object($theme-or-color-config) {
@return $theme-or-color-config;
}

@warn $_legacy-theme-warning;
@return private-create-backwards-compatibility-theme((
_is-legacy-theme: true,
color: $theme-or-color-config
Expand Down