Skip to content

docs(material/badge): don't use inline elements in badge demo #25758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2022
Merged

docs(material/badge): don't use inline elements in badge demo #25758

merged 1 commit into from
Oct 7, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 5, 2022

The badge docs were saying that badges might not work on inline elements while the example was still using inline elements itself. These changes update the example to use div elements instead.

Fixes #25751.

@crisbeto
docs(material/badge): don't use inline elements in badge demo
210220c 
The badge docs were saying that badges might not work on inline elements while the example was still using inline elements itself. These changes update the example to use `div` elements instead.

Fixes angular#25751.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Oct 5, 2022
@crisbeto crisbeto requested a review from andrewseguin as a code owner October 5, 2022 08:24
@angular-robot angular-robot bot added the area: docs Related to the documentation label Oct 5, 2022
@crisbeto crisbeto requested a review from mmalerba October 7, 2022 11:28
mmalerba
mmalerba approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 7, 2022
@crisbeto crisbeto merged commit d75a87d into angular:main Oct 7, 2022
crisbeto added a commit that referenced this pull request Oct 7, 2022
@crisbeto
docs(material/badge): don't use inline elements in badge demo (#25758)
512ba8d 
The badge docs were saying that badges might not work on inline elements while the example was still using inline elements itself. These changes update the example to use `div` elements instead.

Fixes #25751.

(cherry picked from commit d75a87d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs-bug(badge): Example uses inline elements.
2 participants
@crisbeto @mmalerba