Skip to content

docs(material/chips): review migration guide #25826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2022
Merged

docs(material/chips): review migration guide #25826

merged 1 commit into from
Oct 21, 2022

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Oct 17, 2022

Review the migration guide for chips and add more detail to choosing the correct chips component to use.

@zarend
docs(material/chips): review migration guide
6476ab6 
Review the migration guide for chips and add more detail to choosing the
correct chips component to use.
@zarend zarend added docs This issue is related to documentation merge safe area: material/chips labels Oct 17, 2022
@zarend zarend requested review from crisbeto and mmalerba October 17, 2022 14:13
@zarend zarend requested a review from jelbourn as a code owner October 17, 2022 14:13
@angular-robot angular-robot bot added the area: docs Related to the documentation label Oct 17, 2022
crisbeto
crisbeto approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zarend zarend added target: rc This PR is targeted for the next release-candidate action: merge The PR is ready for merge by the caretaker labels Oct 21, 2022
@zarend zarend merged commit acfc24c into angular:main Oct 21, 2022
zarend added a commit that referenced this pull request Oct 21, 2022
@zarend
docs(material/chips): review migration guide (#25826)
34ca293 
Review the migration guide for chips and add more detail to choosing the
correct chips component to use.

(cherry picked from commit acfc24c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: material/chips docs This issue is related to documentation target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zarend @crisbeto