fix(material/tabs): scroll position lost when tab header is hidden #25855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In angular#24885 a `ResizeObserver` was added to the tabs so that the ink bar can re-align if the tab is resized. The problem is that the observer will fire when the tabs become invisible as well, causing the header to re-render using incorrect dimensions. Fixes angular#25574.
crisbeto
added
P3
crisbeto
added a commit
that referenced
this pull request
Oct 24, 2022
…25855) In #24885 a `ResizeObserver` was added to the tabs so that the ink bar can re-align if the tab is resized. The problem is that the observer will fire when the tabs become invisible as well, causing the header to re-render using incorrect dimensions. Fixes #25574. (cherry picked from commit c8d8ef2)
crisbeto
added a commit
that referenced
this pull request
Oct 24, 2022
…25855) In #24885 a `ResizeObserver` was added to the tabs so that the ink bar can re-align if the tab is resized. The problem is that the observer will fire when the tabs become invisible as well, causing the header to re-render using incorrect dimensions. Fixes #25574. (cherry picked from commit c8d8ef2)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Oct 28, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.2.5` -> `14.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.2.5/14.2.6) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.2.5` -> `14.2.6`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.2.5/14.2.6) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v14.2.6`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1426-quilt-seagull-2022-10-26) [Compare Source](angular/components@14.2.5...14.2.6) ##### material | Commit | Type | Description | | -- | -- | -- | | [89771dcc4](angular/components@89771dc) | fix | **tabs:** scroll position lost when tab header is hidden ([#​25855](angular/components#25855)) | #### Special Thanks Kristiyan Kostadinov <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xLjIiLCJ1cGRhdGVkSW5WZXIiOiIzNC4xLjIifQ==--> Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1613 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #24885 a
ResizeObserverwas added to the tabs so that the ink bar can re-align if the tab is resized. The problem is that the observer will fire when the tabs become invisible as well, causing the header to re-render using incorrect dimensions.Fixes #25574.