-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(readme): add link to readme for material2 select #2833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed the CLA! Thanks |
CLAs look good, thanks! |
Shouldn't these just be directly linking to material.angular.io now? The individual READMEs all just have links to material.angular.io. |
@YeomansIII that's what I thought but when I checked the existing main README here: https://github.com/angular/material2 it looks like they are all still linking to the README and then when you click the README link it takes you to a page like this: https://github.com/angular/material2/blob/master/src/lib/snack-bar/README.md which has the link to the docs. I set up my change to match what I was seeing in the existing README but I can update it to link directly to the docs for select at material.angular.io. I just didn't want to do anything that didn't match the setup of what is currently in the main README, in case the preference was to link to the README and have it redirect to the docs (which appears to be the way all the other feature README links are set up right now). |
Not necessarily knocking your pull request, was just kind of an open air question for whoever reviews this. Would make more sense to just link directly to material.angular.io from the root README instead of making people chase it down. |
I agree, and I debated whether to link directly or to link to the README like how the existing one's are set up but then I found this commit: 09591cf and wondered if it was intentional to link to the README which then links to the official docs. This is my first time making a pull request for material2 so I don't totally know the process but I would be happy to update my commit with the direct link if that's preferable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I noticed that the feature list of the README was missing a link to the associated README for the select feature so I updated the docs to include it.