Skip to content

docs(readme): add link to readme for material2 select #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2017
Merged

docs(readme): add link to readme for material2 select #2833

merged 1 commit into from
Feb 3, 2017

Conversation

NColey
Copy link
Contributor

@NColey NColey commented Jan 27, 2017

I noticed that the feature list of the README was missing a link to the associated README for the select feature so I updated the docs to include it.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jan 27, 2017
@NColey
Copy link
Contributor Author

NColey commented Jan 27, 2017

I signed the CLA! Thanks

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jan 27, 2017
@YeomansIII
Copy link
Contributor

Shouldn't these just be directly linking to material.angular.io now? The individual READMEs all just have links to material.angular.io.

@NColey
Copy link
Contributor Author

NColey commented Feb 1, 2017

@YeomansIII that's what I thought but when I checked the existing main README here: https://github.com/angular/material2 it looks like they are all still linking to the README and then when you click the README link it takes you to a page like this: https://github.com/angular/material2/blob/master/src/lib/snack-bar/README.md which has the link to the docs. I set up my change to match what I was seeing in the existing README but I can update it to link directly to the docs for select at material.angular.io. I just didn't want to do anything that didn't match the setup of what is currently in the main README, in case the preference was to link to the README and have it redirect to the docs (which appears to be the way all the other feature README links are set up right now).

@YeomansIII
Copy link
Contributor

YeomansIII commented Feb 1, 2017

Not necessarily knocking your pull request, was just kind of an open air question for whoever reviews this. Would make more sense to just link directly to material.angular.io from the root README instead of making people chase it down.

@NColey
Copy link
Contributor Author

NColey commented Feb 2, 2017

I agree, and I debated whether to link directly or to link to the README like how the existing one's are set up but then I found this commit: 09591cf and wondered if it was intentional to link to the README which then links to the official docs. This is my first time making a pull request for material2 so I don't totally know the process but I would be happy to update my commit with the direct link if that's preferable.

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 3, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara merged commit 4ed259a into angular:master Feb 3, 2017
@NColey NColey deleted the update-docs-feature-readme branch March 25, 2017 17:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants