docs: test colors for progress components in demo-app #2841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tinayuangao
added
pr: lgtm
action: merge
* Refactors the progress-bar and progress-spinner demos to have a dynamic `color` binding in the demo. This is useful to test if the colors are properly applied to the progress-bar and `progress-spinner` components. * Also clamps the values in the `progress-bar` and `progress-spinner` demos to make the demo feel better.
devversion
force-pushed
the
docs/progress-demos
branch
from
e781f02 to
434e9af
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the progress-bar and progress-spinner demos to have a dynamic
colorbinding in the demo.This is useful to test if the colors are properly applied to the progress-bar and
progress-spinnercomponents.Also clamps the values in the
progress-barandprogress-spinnerdemos to make the demo feel better.Note: Also most of the progress-demo elements just have been moved above the demo and now align nicer.
References #2813