Skip to content

refactor(material/theming): make batch-create-token-values more flexible #28897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2024
Merged

refactor(material/theming): make batch-create-token-values more flexible #28897

merged 1 commit into from
Apr 18, 2024

Conversation

wagnermaciel
Copy link
Contributor

  • Refactor token-utils.batch-create-token-values to allow us to pass in as many token maps as we want. This is change is relevant for components like the button which would want to pass in token maps for each button variant.

@wagnermaciel
refactor(material/theming): make batch-create-token-values more flexible
eb18c90 
* Refactor token-utils.batch-create-token-values to allow us to pass in as many token maps as
  we want. This is change is relevant for components like the button which would want to pass
  in token maps for each button variant.
@wagnermaciel wagnermaciel requested a review from crisbeto April 17, 2024 20:10
@wagnermaciel wagnermaciel marked this pull request as ready for review April 17, 2024 20:18
@wagnermaciel wagnermaciel requested a review from mmalerba as a code owner April 17, 2024 20:18
@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 18, 2024
@wagnermaciel wagnermaciel removed the request for review from mmalerba April 18, 2024 15:19
@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release labels Apr 18, 2024
@wagnermaciel wagnermaciel merged commit 9b2e9b7 into angular:main Apr 18, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagnermaciel @crisbeto