fix(material/core): ripple loader not working in shadow DOM #29015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following issues that prevented the button ripples from being loaded in the shadow DOM: * We weren't resolving the event target properly. * We were using `click` as a fallback which happens too late for the very first ripple. These changes switch to `mousedown`. Fixes angular#29011.
1 task
amysorto
approved these changes
May 8, 2024
crisbeto
added
action: merge
crisbeto
added a commit
that referenced
this pull request
May 9, 2024
Fixes the following issues that prevented the button ripples from being loaded in the shadow DOM: * We weren't resolving the event target properly. * We were using `click` as a fallback which happens too late for the very first ripple. These changes switch to `mousedown`. Fixes #29011. (cherry picked from commit 7553e1c)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues that prevented the button ripples from being loaded in the shadow DOM:
clickas a fallback which happens too late for the very first ripple. These changes switch tomousedown.Fixes #29011.