test(menu): remove provideZoneChangeDetection for all menu tests #29061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes 'provideZoneChangeDetection' from menu tests. Change summary: * Many tests set inputs directly. This isn't really how it happens in applications - inputs set from the template automatically mark components for check. When tests set inputs directly like this, they need to call `markForCheck` manually (or something similar). * Similarly, test components need to be marked for check when setting values * One test seems to be calling a public API (`CdkContextMenuTrigger.open`) that failed to call `markForCheck` so that was added to the implementation * `fakeAsync` had an additional timer so I just added `flush` to make it work.
atscott
force-pushed
the
zonelesstestsmore
branch
from
0f8524d to
3cf2cb9
Compare
crisbeto
approved these changes
May 16, 2024
mmalerba
approved these changes
May 21, 2024
mmalerba
approved these changes
May 21, 2024
mmalerba
pushed a commit
that referenced
this pull request
May 21, 2024
…29061) This removes 'provideZoneChangeDetection' from menu tests. Change summary: * Many tests set inputs directly. This isn't really how it happens in applications - inputs set from the template automatically mark components for check. When tests set inputs directly like this, they need to call `markForCheck` manually (or something similar). * Similarly, test components need to be marked for check when setting values * One test seems to be calling a public API (`CdkContextMenuTrigger.open`) that failed to call `markForCheck` so that was added to the implementation * `fakeAsync` had an additional timer so I just added `flush` to make it work. (cherry picked from commit 325533a)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes 'provideZoneChangeDetection' from menu tests. Change summary:
markForCheckmanually (or something similar).CdkContextMenuTrigger.open) that failed to callmarkForCheckso that was added to the implementationfakeAsynchad an additional timer so I just addedflushto make it work.