Skip to content

docs: fix progress-bar color demo #2915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2017

Conversation

devversion
Copy link
Member

Fixes #2813

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 3, 2017
@kara
Copy link
Contributor

kara commented Feb 6, 2017

@devversion We are still building the docs examples from the material.angular.io repo (only halfway through the transition to this repo), so you'll need to make the change there for it actually to be reflected: https://github.com/angular/material.angular.io

That said, we will also need to keep the change in this repo for when the transition is over. I'll LGTM once it's present in both so they are kept in sync.

@kara kara assigned devversion and unassigned kara Feb 6, 2017
@devversion
Copy link
Member Author

@kara Ah I thought that doing the change only in the material2 repository is fine. See docs PR

@devversion devversion assigned kara and unassigned devversion Feb 6, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 6, 2017
@kara
Copy link
Contributor

kara commented Feb 6, 2017

@tinayuangao Can you merge angular/material.angular.io#94 before or at the same time as this one?

@kara kara removed their assignment Feb 6, 2017
@tinayuangao tinayuangao merged commit 328f7ef into angular:master Feb 6, 2017
@devversion devversion deleted the docs/fix-progress-bar-demo branch February 7, 2017 06:05
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components Examples Bug: Changing Color of progress bars don't work.
4 participants