Skip to content

docs-bug(mat-table): Example suggesting to use max-width to set column width is misleading #29373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2024
Merged

docs-bug(mat-table): Example suggesting to use max-width to set column width is misleading #29373

merged 1 commit into from
Jul 5, 2024

Conversation

lindoRR-07
Copy link
Contributor

The fix is to use the width property instead of max-width since this can be misleading as though the width will never exceed the max-width provided.

Fixes #29294

@lindoRR-07
docs-bug(mat-table): Example suggesting to use max-width to set colum…
d921ad8 
…n width is misleading

The fix is to use the width property instead of max-width since this can be misleading as though the width will never exceed the max-width provided.

Fixes angular#29294
@lindoRR-07 lindoRR-07 requested a review from a team as a code owner July 3, 2024 09:21
@lindoRR-07 lindoRR-07 requested review from crisbeto and mmalerba and removed request for a team July 3, 2024 09:21
@crisbeto crisbeto removed the request for review from mmalerba July 5, 2024 10:35
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Jul 5, 2024
@crisbeto crisbeto merged commit 045806b into angular:main Jul 5, 2024
13 checks passed
crisbeto pushed a commit that referenced this pull request Jul 5, 2024
@lindoRR-07 @crisbeto
docs(material/table): Example suggesting to use max-width to set colu…
6c71f8a 
…mn width is misleading (#29373)

The fix is to use the width property instead of max-width since this can be misleading as though the width will never exceed the max-width provided.

(cherry picked from commit 045806b)
crisbeto pushed a commit that referenced this pull request Jul 5, 2024
@lindoRR-07 @crisbeto
docs(material/table): Example suggesting to use max-width to set colu…
6142d6a 
…mn width is misleading (#29373)

The fix is to use the width property instead of max-width since this can be misleading as though the width will never exceed the max-width provided.

(cherry picked from commit 045806b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs-bug(mat-table): Example suggesting to use max-width to set column width is misleading
2 participants
@lindoRR-07 @crisbeto