fix(cdk/dialog): CDK Dialog docs missing explanation on how to access dialogRef when using a TemplateRef #29381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dialogRef when using a TemplateRef Updated the dialog in the cdk to add an example on accessing the dialogRef when using TemplateRef Fixes angular#26193
MichelleRetroRabbit
requested review from
crisbeto and
andrewseguin
and removed request for
a team
crisbeto
reviewed
Jul 5, 2024
… dialogRef when using a TemplateRef Updated wording used to explain the example. Fixes angular#26193
crisbeto
approved these changes
Jul 9, 2024
crisbeto
added
docs
crisbeto
pushed a commit
that referenced
this pull request
Jul 9, 2024
…s dialogRef when using a TemplateRef (#29381) * fix(cdk/dialog): CDK Dialog docs missing explanation on how to access dialogRef when using a TemplateRef Updated the dialog in the cdk to add an example on accessing the dialogRef when using TemplateRef Fixes #26193 * fix(cdk/dialog): CDK Dialog docs missing explanation on how to access dialogRef when using a TemplateRef Updated wording used to explain the example. Fixes #26193 (cherry picked from commit 3d1ca53)
crisbeto
pushed a commit
that referenced
this pull request
Jul 9, 2024
…s dialogRef when using a TemplateRef (#29381) * fix(cdk/dialog): CDK Dialog docs missing explanation on how to access dialogRef when using a TemplateRef Updated the dialog in the cdk to add an example on accessing the dialogRef when using TemplateRef Fixes #26193 * fix(cdk/dialog): CDK Dialog docs missing explanation on how to access dialogRef when using a TemplateRef Updated wording used to explain the example. Fixes #26193 (cherry picked from commit 3d1ca53)
DBowen33
pushed a commit
to DBowen33/components
that referenced
this pull request
Jul 12, 2024
…s dialogRef when using a TemplateRef (angular#29381) * fix(cdk/dialog): CDK Dialog docs missing explanation on how to access dialogRef when using a TemplateRef Updated the dialog in the cdk to add an example on accessing the dialogRef when using TemplateRef Fixes angular#26193 * fix(cdk/dialog): CDK Dialog docs missing explanation on how to access dialogRef when using a TemplateRef Updated wording used to explain the example. Fixes angular#26193
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the dialog in the cdk to add an example on accessing the dialogRef when using TemplateRef
Fixes #26193