Skip to content

fixed show scrollbar in preview of the last element #29450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

josuVazquez
Copy link
Contributor

The style border-bottom: solid 1px #ccc; was initially applied to all elements with the class example-box, except for the last child which had its border removed with border: none. However, when the last element was dragged, it lost the border: none style and regained the border-bottom: 1px solid #ccc, causing the scrollbar to appear.

To fix this issue, I applied border: none to the class cdk-drag-preview. This ensures that all dragged elements lose their border-bottom, preventing the scrollbar from appearing during the drag operation.

Fixes #29419

@josuVazquez josuVazquez requested a review from a team as a code owner July 17, 2024 18:32
@josuVazquez josuVazquez requested review from amysorto and mmalerba and removed request for a team July 17, 2024 18:32
@mmalerba mmalerba requested review from crisbeto and removed request for mmalerba July 17, 2024 21:21
@josuVazquez josuVazquez force-pushed the fix/docs-bug-drag-drop-scrollbar branch from ce52102 to b6b0b5d Compare July 17, 2024 21:45
@crisbeto crisbeto removed the request for review from amysorto July 18, 2024 07:52
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Jul 18, 2024
@crisbeto crisbeto merged commit e517789 into angular:main Jul 18, 2024
11 of 13 checks passed
crisbeto pushed a commit that referenced this pull request Jul 18, 2024
@josuVazquez josuVazquez deleted the fix/docs-bug-drag-drop-scrollbar branch July 18, 2024 11:12
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs-bug(drag-drop): Dragging last element in a list shows scrollbar in the preview.
2 participants