build: move commit message check to be last in pipeline #29568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It occasionally happens that we get a PR that has both the incorrect commit message and a lint failure. The process of fixing it can take multiple runs, because the author has to fix the commit, re-run and then fix the lint failures. These changes move the commit message check to be last since if everything else passes, the caretaker can fix the commit message while merging the PR.
angular-robot
bot
added
the
area: build & ci
devversion
approved these changes
Aug 12, 2024
crisbeto
added a commit
that referenced
this pull request
Aug 12, 2024
It occasionally happens that we get a PR that has both the incorrect commit message and a lint failure. The process of fixing it can take multiple runs, because the author has to fix the commit, re-run and then fix the lint failures. These changes move the commit message check to be last since if everything else passes, the caretaker can fix the commit message while merging the PR. (cherry picked from commit 64dfcc0)
crisbeto
added a commit
that referenced
this pull request
Aug 12, 2024
It occasionally happens that we get a PR that has both the incorrect commit message and a lint failure. The process of fixing it can take multiple runs, because the author has to fix the commit, re-run and then fix the lint failures. These changes move the commit message check to be last since if everything else passes, the caretaker can fix the commit message while merging the PR. (cherry picked from commit 64dfcc0)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It occasionally happens that we get a PR that has both the incorrect commit message and a lint failure. The process of fixing it can take multiple runs, because the author has to fix the commit, re-run and then fix the lint failures.
These changes move the commit message check to be last since if everything else passes, the caretaker can fix the commit message while merging the PR.