feat(dialog): allow setting the layout direction #4778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
May 24, 2017
|
|
||
| let overlayPane = overlayContainerElement.querySelector('.cdk-overlay-pane'); | ||
|
|
||
| expect(overlayPane.getAttribute('dir')).toBe('rtl'); |
There was a problem hiding this comment.
optional: shorter to just to overlayPane.dir
There was a problem hiding this comment.
I have some vague memories about trying that a while ago and failing in IE.
jelbourn
added
pr: lgtm
action: merge
Allows users to set the layout direction of a dialog.
crisbeto
force-pushed
the
dialog-direction
branch
from
c3a29d2 to
0c07edb
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to set the layout direction of a dialog.