Skip to content

build: add dashboard firebase functions #4806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2017

Conversation

devversion
Copy link
Member

  • Adds a new folder for the dashboard project that for now only contains firebase functions.
  • The firebase functions will be used to securely make API calls to the Github API (e.g payload status)
  • Functions will be automatically deployed as same as screenshot functions.

Required for future dashboard features and stuff like #4460

@devversion devversion requested a review from jelbourn May 25, 2017 17:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 25, 2017
@devversion devversion force-pushed the build/dashboard-functions branch 2 times, most recently from 6e98768 to e8f8517 Compare May 26, 2017 17:31
@devversion
Copy link
Member Author

@jelbourn Made the changes we talked about on Slack. Let me know if we should improve anything with the functions.ts file.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Adds a new folder for the dashboard project that for now only contains firebase functions.
* The firebase functions will be used to securely make API calls to the Github API (e.g payload status)
* Functions will be automatically deployed as same as screenshot functions.
@devversion devversion force-pushed the build/dashboard-functions branch from e8f8517 to 6a853f6 Compare May 27, 2017 07:49
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels May 27, 2017
@mmalerba mmalerba merged commit 964033c into angular:master May 31, 2017
@devversion devversion deleted the build/dashboard-functions branch November 11, 2017 10:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants