build: add stylelint rule to prevent usage of /deep/ #4841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a custom Stylelint rule to prevent usages of `/deep/` inside selectors. Relates angular#4726.
googlebot
added
the
cla: yes
jelbourn
reviewed
May 30, 2017
|
|
||
| const ruleName = 'material/selector-no-deep'; | ||
| const messages = stylelint.utils.ruleMessages(ruleName, { | ||
| expected: selector => `Usage of the /deep/ in "${selector}" is now allowed`, |
There was a problem hiding this comment.
"now allowed" -> "not allowed"
| if (rule.parent.type === 'rule' && | ||
| isStandardSyntaxRule(rule) && | ||
| isStandardSyntaxSelector(rule.selector) && | ||
| rule.selector.indexOf('/deep/') > -1) { |
There was a problem hiding this comment.
rule.selector.includes('/deep/') ?
There was a problem hiding this comment.
I'm not sure what the support for that one is in Node. It's not terribly good in browsers.
There was a problem hiding this comment.
It's fine in node. I use it all the time in our dgeni tooling
|
Addressed the feedback @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a custom Stylelint rule to prevent usages of
/deep/inside selectors.Relates #4726.