-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: add missing bits for material-examples package #4887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/material-examples/typings.d.ts
Outdated
@@ -0,0 +1 @@ | |||
declare var module: {id: string}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this module.id available in plunkers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The moduleId should be removed by the inline resources script. Why do we need it at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was part of my debugging process. It ended up not being the problem, but I left it because the material2 components themselves use it. However, I didn't think of the plunkers. It looks like I failed to update how those work at all. Fixing that now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Basically they shouldn't be necessary at all. It's fine to leave them for now though.
Just want to check. Does something need the moduleId in our development? (e.g Google internally)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes- Google uses it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright that makes sense then. For the examples you removed the module.id
. You can remove the typings file therefore too
Updated to remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One minor comment about the unused typing file.
Adds: * Missing `flatModuleId` from the ngc options * Makes templateUrl and styleUrls for example components match material components.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds:
flatModuleId
from the ngc optionsmodule
in order to set moduleIdcomponents.