build: fix universal prerendering task #4931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Fixes the Universal Prerendering task by using the same workaround as for the AOT job (building sources in the output directory already) Building the sources in the output directory (similar as for the AOT task) is theonly known workaround for angular/angular#12249
devversion
force-pushed
the
build/fix-universal-task
branch
from
d103d1c to
586e56a
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the Universal Prerendering task by using the same workaround as for the AOT job (building sources in the output directory already)
Building the sources in the output directory (similar as for the AOT task) is the only known workaround for angular/angular#12249
When building the files the TypeScript path mapping functionality is used to map
@angular/materialto the correct path. But when running theprerenderscript this is not working and it won't find the package.Using the
tsconfig-pathsnpm module can handle such path mapping at runtime. It also uses the TSConfig file which helps us not duplicating the mapping.Copying the different packages to the
node_modules/may work too, but it's more elegant to just use thetsconfig-pathsmodule since it uses the tsconfig file already.