build: enable no-unused-variable lint rule #5184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Jun 17, 2017
| @@ -1,16 +1,9 @@ | |||
| import {NativeDateAdapter} from './native-date-adapter'; | |||
| import {Platform} from '../platform/index'; | |||
|
|
|||
| import {DEC, FEB, JAN, MAR} from '../testing/date-shortcuts'; | |||
jelbourn
added
pr: lgtm
action: merge
devversion
force-pushed
the
build/lint-unused-variables
branch
from
23d5920 to
80681c4
Compare
|
please rebase |
mmalerba
added
pr: needs rebase
and removed
action: merge
devversion
force-pushed
the
build/lint-unused-variables
branch
from
80681c4 to
61b5ae3
Compare
devversion
added
action: merge
|
@mmalerba Done. |
|
sorry, needs more rebase :p |
devversion
force-pushed
the
build/lint-unused-variables
branch
from
61b5ae3 to
0076659
Compare
* Now TSLint starts reporting unused variables again (Rule has been un-deprecated and now uses the type checker * In favor of linting the whole project the tsconfig file inside of `src/` needs to live in the project root.
devversion
force-pushed
the
build/lint-unused-variables
branch
from
0076659 to
ed10e21
Compare
|
Done 😄 |
devversion
added
action: merge
amcdnl
pushed a commit
to amcdnl/material2
that referenced
this pull request
Jul 8, 2017
* Now TSLint starts reporting unused variables again (Rule has been un-deprecated and now uses the type checker * In favor of linting the whole project the tsconfig file inside of `src/` needs to live in the project root.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/needs to live in the project root.