Skip to content

Fix typo which caused CdkHeaderRow to be used instead of CdkRow in MdTable row #5433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

swftvsn
Copy link
Contributor

@swftvsn swftvsn commented Jun 30, 2017

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jun 30, 2017
@swftvsn
Copy link
Contributor Author

swftvsn commented Jun 30, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jun 30, 2017
@swftvsn
Copy link
Contributor Author

swftvsn commented Jun 30, 2017

@jelbourn This is only a minor typo fix, prolly faster to just change it and commit in. Anyway, testing the new table results now all rows to be underlined due to (atleast I suspect) this.

@andrewseguin andrewseguin added Accessibility This issue is related to accessibility (a11y) pr: lgtm action: merge The PR is ready for merge by the caretaker and removed Accessibility This issue is related to accessibility (a11y) pr: needs review labels Jun 30, 2017
@andrewseguin
Copy link
Contributor

Good catch, thanks for fixing that up. Little concerned that the tests didn't catch this.

@tinayuangao tinayuangao merged commit c9f7f46 into angular:master Jun 30, 2017
amcdnl pushed a commit to amcdnl/material2 that referenced this pull request Jul 8, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants