Skip to content

demos(*): fix inputs spilling over when screen width small #6155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2017

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Jul 30, 2017

Fixes the autocomplete and input examples with a fixed 500px width from spilling over on smaller device screens.

img

@amcdnl amcdnl self-assigned this Jul 30, 2017
@amcdnl amcdnl requested a review from jelbourn July 30, 2017 16:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 30, 2017
@fxck
Copy link
Contributor

fxck commented Jul 31, 2017

Wouldn't it be worth adding a global .example-form class rather than having the same repeat in each demo.. or at least use variable for those values?

@jelbourn
Copy link
Member

@fxck the examples are all meant to be totally standalone so you can just look at one to see what's going on

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 31, 2017
@tinayuangao tinayuangao merged commit 51eca3b into angular:master Aug 1, 2017
@amcdnl amcdnl deleted the demo-width-fixes branch August 1, 2017 21:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants