chore: fix invalid paths for codeowner folders #6191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub code owners feature does not work properly right now because the different paths/globs to the folders (like the `input`) are not matching at all. This is because the paths are not absolute nor relative paths but still include a directory name. This does not work properly and can be confirmed by playing with the `.gitignore` (which has the same pattern matching)
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub code owners feature does not work properly right now because the different paths/globs to the folders (like the
input) are not matching at all.This is because the paths are not absolute nor relative paths but still include a directory name. This does not work properly and can be confirmed by playing with the
.gitignore(which has the same pattern matching)For example something like that (which is nor a absolute/relative path) would match every
input/directory in the project. But as soon as this will be extended to work as a glob this won't work anymore.