Skip to content

fix(snackbar): Docs example fixes #6990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2017
Merged

fix(snackbar): Docs example fixes #6990

merged 1 commit into from
Sep 29, 2017

Conversation

josephperrott
Copy link
Member

@josephperrott josephperrott commented Sep 11, 2017 •
edited
Loading

For #6952 #6951

  • Move snackbar inline
  • Load card icons from urls absolutely rather than relatively

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 11, 2017
@josephperrott josephperrott changed the title fix: Move snackbar component styling to inline for docs example fix(snackbar): Move snackbar component styling to inline for docs example Sep 12, 2017
@josephperrott josephperrott changed the title fix(snackbar): Move snackbar component styling to inline for docs example fix(snackbar): Docs example fixes Sep 12, 2017
jelbourn
jelbourn approved these changes Sep 13, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 13, 2017
@jelbourn
Copy link
Member

@josephperrott can you rebase?

@andrewseguin andrewseguin merged commit f43bf23 into angular:master Sep 29, 2017
@josephperrott josephperrott mentioned this pull request Oct 3, 2017
Closed
@josephperrott josephperrott mentioned this pull request Oct 16, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephperrott @jelbourn @googlebot @andrewseguin