fix(sidenav-fab-example):removed overflow:auto; since there is no need for it #7099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
requested review from
mmalerba
and removed request for
amcdnl and
jelbourn
mmalerba
reviewed
Sep 15, 2017
| @@ -14,10 +14,6 @@ | |||
| overflow: visible; | |||
| } | |||
|
|
|||
| .example-scrolling-content { | |||
There was a problem hiding this comment.
This is actually needed because the same class is used to make the sidenav content scroll. Actually can you add height: 100% to this instead? That should fix the issue where the FAB button in the content section scrolls up instead of staying fixed:
.example-scrolling-content {
overflow: auto;
height: 100%;
}There was a problem hiding this comment.
Thank you , I fixed it in the next commit
Fixed review comments
mmalerba
added
pr: lgtm
action: merge
mmalerba
approved these changes
Sep 18, 2017
This was referenced Sep 18, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6937