Skip to content

fix: remove cdk re-exports from @angular/material #7112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes.
10 changes: 5 additions & 5 deletions src/cdk/a11y/focus-monitor.spec.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import {ComponentFixture, inject, TestBed, fakeAsync, tick} from '@angular/core/testing';
import {Component, Renderer2} from '@angular/core';
import {A11yModule} from './index';
import {By} from '@angular/platform-browser';
import {TAB} from '@angular/cdk/keycodes';
import {FocusOrigin, FocusMonitor, TOUCH_BUFFER_MS} from './focus-monitor';
import {dispatchFakeEvent, dispatchKeyboardEvent, dispatchMouseEvent} from '@angular/cdk/testing';
import {Component, Renderer2} from '@angular/core';
import {ComponentFixture, fakeAsync, inject, TestBed, tick} from '@angular/core/testing';
import {By} from '@angular/platform-browser';
import {FocusMonitor, FocusOrigin, TOUCH_BUFFER_MS} from './focus-monitor';
import {A11yModule} from './index';


describe('FocusMonitor', () => {
Expand Down
4 changes: 2 additions & 2 deletions src/cdk/a11y/focus-monitor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/

import {Platform} from '@angular/cdk/platform';
import {
Directive,
ElementRef,
Expand All @@ -18,11 +19,10 @@ import {
Renderer2,
SkipSelf,
} from '@angular/core';
import {Platform} from '@angular/cdk/platform';
import {Observable} from 'rxjs/Observable';
import {of as observableOf} from 'rxjs/observable/of';
import {Subject} from 'rxjs/Subject';
import {Subscription} from 'rxjs/Subscription';
import {of as observableOf} from 'rxjs/observable/of';


// This is the value used by AngularJS Material. Through trial and error (on iPhone 6S) they found
Expand Down
6 changes: 3 additions & 3 deletions src/cdk/a11y/focus-trap.spec.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import {ComponentFixture, TestBed, async} from '@angular/core/testing';
import {Platform} from '@angular/cdk/platform';
import {Component, ViewChild} from '@angular/core';
import {FocusTrapFactory, FocusTrapDirective, FocusTrap} from './focus-trap';
import {async, ComponentFixture, TestBed} from '@angular/core/testing';
import {FocusTrap, FocusTrapDirective, FocusTrapFactory} from './focus-trap';
import {InteractivityChecker} from './interactivity-checker';
import {Platform} from '../platform/platform';


describe('FocusTrap', () => {
Expand Down
3 changes: 2 additions & 1 deletion src/cdk/a11y/interactivity-checker.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {Platform} from '@angular/cdk/platform';
import {InteractivityChecker} from './interactivity-checker';
import {Platform} from '../platform/platform';


describe('InteractivityChecker', () => {
let testContainerElement: HTMLElement;
Expand Down
8 changes: 4 additions & 4 deletions src/cdk/a11y/list-key-manager.spec.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import {DOWN_ARROW, TAB, UP_ARROW} from '@angular/cdk/keycodes';
import {first} from '@angular/cdk/rxjs';
import {QueryList} from '@angular/core';
import {fakeAsync, tick} from '@angular/core/testing';
import {createKeyboardEvent} from '../testing/event-objects';
import {ActiveDescendantKeyManager} from './activedescendant-key-manager';
import {FocusKeyManager} from './focus-key-manager';
import {DOWN_ARROW, UP_ARROW, TAB} from '../keycodes/keycodes';
import {ListKeyManager} from './list-key-manager';
import {ActiveDescendantKeyManager} from './activedescendant-key-manager';
import {createKeyboardEvent} from '../testing/event-objects';
import {first} from '../rxjs/index';


class FakeFocusable {
Expand Down
1 change: 1 addition & 0 deletions src/cdk/portal/public_api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@
export * from './portal';
export * from './dom-portal-host';
export * from './portal-directives';
export * from './portal-injector';
6 changes: 4 additions & 2 deletions src/demo-app/snack-bar/snack-bar-demo.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import {Dir} from '@angular/cdk/bidi';
import {Component, ViewEncapsulation} from '@angular/core';
import {
MdSnackBar,
MdSnackBarConfig,
MdSnackBarHorizontalPosition,
MdSnackBarVerticalPosition,
Dir,
} from '@angular/material';


@Component({
moduleId: module.id,
selector: 'snack-bar-demo',
Expand All @@ -25,7 +26,8 @@ export class SnackBarDemo {
horizontalPosition: MdSnackBarHorizontalPosition = 'center';
verticalPosition: MdSnackBarVerticalPosition = 'bottom';

constructor(public snackBar: MdSnackBar, private dir: Dir) { }
constructor(public snackBar: MdSnackBar, private dir: Dir) {
}

open() {
let config = new MdSnackBarConfig();
Expand Down
30 changes: 15 additions & 15 deletions src/lib/autocomplete/autocomplete.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
import {async, ComponentFixture, fakeAsync, TestBed, tick} from '@angular/core/testing';
import {Direction, Directionality} from '@angular/cdk/bidi';
import {DOWN_ARROW, ENTER, ESCAPE, SPACE, UP_ARROW} from '@angular/cdk/keycodes';
import {OverlayContainer} from '@angular/cdk/overlay';
import {map, RxChain, startWith} from '@angular/cdk/rxjs';
import {ScrollDispatcher} from '@angular/cdk/scrolling';
import {createKeyboardEvent, dispatchFakeEvent, typeInElement} from '@angular/cdk/testing';
import {
ChangeDetectionStrategy,
Component,
Expand All @@ -8,28 +13,23 @@ import {
ViewChild,
ViewChildren,
} from '@angular/core';
import {async, ComponentFixture, fakeAsync, TestBed, tick} from '@angular/core/testing';
import {FormControl, FormsModule, ReactiveFormsModule} from '@angular/forms';
import {MdOption} from '@angular/material/core';
import {MdFormField, MdFormFieldModule} from '@angular/material/form-field';
import {By} from '@angular/platform-browser';
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
import {FormControl, FormsModule, ReactiveFormsModule} from '@angular/forms';
import {ScrollDispatcher} from '@angular/cdk/scrolling';
import {OverlayContainer} from '@angular/cdk/overlay';
import {Direction, Directionality} from '@angular/cdk/bidi';
import {map, RxChain, startWith} from '@angular/cdk/rxjs';
import {createKeyboardEvent, dispatchFakeEvent, typeInElement} from '@angular/cdk/testing';
import {Observable} from 'rxjs/Observable';
import {Subject} from 'rxjs/Subject';
import {Subscription} from 'rxjs/Subscription';
import {MdInputModule} from '../input/index';
import {
getMdAutocompleteMissingPanelError,
MdAutocomplete,
MdAutocompleteModule,
MdAutocompleteTrigger,
MdAutocompleteSelectedEvent,
MdAutocompleteTrigger,
} from './index';
import {MdInputModule} from '../input/index';
import {Subscription} from 'rxjs/Subscription';
import {DOWN_ARROW, ENTER, ESCAPE, SPACE, UP_ARROW} from '@angular/material/core';
import {MdOption} from '@angular/material/core';
import {MdFormField, MdFormFieldModule} from '@angular/material/form-field';
import {Observable} from 'rxjs/Observable';
import {Subject} from 'rxjs/Subject';


describe('MdAutocomplete', () => {
Expand Down
1 change: 0 additions & 1 deletion src/lib/button-toggle/button-toggle.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
@import '../core/a11y/a11y';
@import '../core/style/elevation';
@import '../core/style/vendor-prefixes';
@import '../core/style/layout-common';
Expand Down
2 changes: 1 addition & 1 deletion src/lib/button/button.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// TODO(jelbourn): Measure perf benefits for translate3d and will-change.
// TODO(jelbourn): Figure out if anchor hover underline actually happens in any browser.
@import 'button-base';
@import '../core/a11y/a11y';
@import '../../cdk/a11y/a11y';
@import '../core/style/layout-common';

.mat-button, .mat-icon-button {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/card/card.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@import '../core/style/variables';
@import '../core/style/elevation';
@import '../core/a11y/a11y';
@import '../../cdk/a11y/a11y';


$mat-card-default-padding: 24px !default;
Expand Down
14 changes: 7 additions & 7 deletions src/lib/chips/chip-input.spec.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import {async, TestBed, ComponentFixture} from '@angular/core/testing';
import {MdChipsModule} from './index';
import {Directionality} from '@angular/cdk/bidi';
import {ENTER} from '@angular/cdk/keycodes';
import {PlatformModule} from '@angular/cdk/platform';
import {createKeyboardEvent} from '@angular/cdk/testing';
import {Component, DebugElement} from '@angular/core';
import {PlatformModule} from '../core/platform/index';
import {MdChipInput, MdChipInputEvent} from './chip-input';
import {async, ComponentFixture, TestBed} from '@angular/core/testing';
import {By} from '@angular/platform-browser';
import {Directionality} from '@angular/material/core';
import {createKeyboardEvent} from '@angular/cdk/testing';
import {MdChipInput, MdChipInputEvent} from './chip-input';
import {MdChipsModule} from './index';

import {ENTER} from '@angular/material/core';

const COMMA = 188;

Expand Down
11 changes: 3 additions & 8 deletions src/lib/chips/chip-input.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,12 @@
* found in the LICENSE file at https://angular.io/license
*/

import {
Directive,
ElementRef,
Output,
EventEmitter,
Input,
} from '@angular/core';
import {coerceBooleanProperty} from '@angular/cdk/coercion';
import {ENTER} from '@angular/material/core';
import {ENTER} from '@angular/cdk/keycodes';
import {Directive, ElementRef, EventEmitter, Input, Output,} from '@angular/core';
import {MdChipList} from './chip-list';


export interface MdChipInputEvent {
input: HTMLInputElement;
value: string;
Expand Down
13 changes: 2 additions & 11 deletions src/lib/chips/chip-list.spec.ts
Original file line number Diff line number Diff line change
@@ -1,22 +1,13 @@
import {FocusKeyManager} from '@angular/cdk/a11y';
import {Directionality} from '@angular/cdk/bidi';
import {BACKSPACE, DELETE, ENTER, LEFT_ARROW, RIGHT_ARROW, SPACE, TAB} from '@angular/cdk/keycodes';
import {createKeyboardEvent, dispatchFakeEvent, dispatchKeyboardEvent} from '@angular/cdk/testing';
import {Component, DebugElement, QueryList, ViewChild, ViewChildren} from '@angular/core';
import {async, ComponentFixture, fakeAsync, TestBed, tick} from '@angular/core/testing';
import {FormControl, FormsModule, ReactiveFormsModule} from '@angular/forms';
import {
BACKSPACE,
DELETE,
Directionality,
ENTER,
LEFT_ARROW,
RIGHT_ARROW,
SPACE,
TAB,
} from '@angular/material/core';
import {MdFormFieldModule} from '@angular/material/form-field';
import {By} from '@angular/platform-browser';
import {NoopAnimationsModule} from '@angular/platform-browser/animations';

import {MdInputModule} from '../input/index';
import {MdChip} from './chip';
import {MdChipInputEvent} from './chip-input';
Expand Down
15 changes: 4 additions & 11 deletions src/lib/chips/chip-list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,17 @@
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/

import {FocusKeyManager} from '@angular/cdk/a11y';
import {Directionality} from '@angular/cdk/bidi';
import {coerceBooleanProperty} from '@angular/cdk/coercion';
import {SelectionModel} from '@angular/cdk/collections';
import {BACKSPACE, DELETE, LEFT_ARROW, RIGHT_ARROW, UP_ARROW,} from '@angular/cdk/keycodes';
import {startWith} from '@angular/cdk/rxjs';
import {
AfterContentInit,
ChangeDetectorRef,
ChangeDetectionStrategy,
ChangeDetectorRef,
Component,
ContentChildren,
ElementRef,
Expand All @@ -28,21 +31,11 @@ import {
ViewEncapsulation,
} from '@angular/core';
import {ControlValueAccessor, FormGroupDirective, NgControl, NgForm} from '@angular/forms';
import {
BACKSPACE,
DELETE,
Directionality,
LEFT_ARROW,
RIGHT_ARROW,
UP_ARROW
} from '@angular/material/core';
import {MdFormFieldControl} from '@angular/material/form-field';

import {Observable} from 'rxjs/Observable';
import {merge} from 'rxjs/observable/merge';
import {Subject} from 'rxjs/Subject';
import {Subscription} from 'rxjs/Subscription';

import {MdChip, MdChipEvent, MdChipSelectionChange} from './chip';
import {MdChipInput} from './chip-input';

Expand Down
11 changes: 6 additions & 5 deletions src/lib/chips/chip.spec.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import {Directionality} from '@angular/cdk/bidi';
import {BACKSPACE, DELETE, SPACE} from '@angular/cdk/keycodes';
import {createKeyboardEvent} from '@angular/cdk/testing';
import {Component, DebugElement} from '@angular/core';
import {async, ComponentFixture, TestBed} from '@angular/core/testing';
import {Component, DebugElement} from '@angular/core';
import {By} from '@angular/platform-browser';
import {createKeyboardEvent} from '@angular/cdk/testing';
import {MdChipList, MdChip, MdChipEvent, MdChipsModule, MdChipSelectionChange} from './index';
import {SPACE, DELETE, BACKSPACE} from '@angular/material/core';
import {Directionality} from '@angular/material/core';
import {MdChip, MdChipEvent, MdChipList, MdChipSelectionChange, MdChipsModule} from './index';


describe('Chips', () => {
let fixture: ComponentFixture<any>;
Expand Down
Loading