chore: Make accessibility demo page focus goes to header after clicki… #7188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tinayuangao
added
the
Accessibility
jelbourn
reviewed
Sep 19, 2017
src/demo-app/a11y/a11y.html
Outdated
| {{navItem.name}} | ||
| </a> | ||
| </nav> | ||
|
|
||
| <div #maincontent tabindex="0"> | ||
| <h1 #header tabindex="0" *ngIf="!!currentComponent">{{currentComponent}} Demo</h1> |
There was a problem hiding this comment.
We should make the tabindex="-1" so that it can be focused programmatically without being in the tab order
| skipNavigation() { | ||
| this.mainContent.nativeElement.scrollIntoView(); | ||
| this.mainContent.nativeElement.focus(); | ||
| (this.currentComponent ? this.sectionHeader : this.mainContent).nativeElement.focus(); |
There was a problem hiding this comment.
Did you find that this worked well without a timeout? If so that works for me.
There was a problem hiding this comment.
This worked well without a timeout. I tested with chromeVox and VoiceOver.
tinayuangao
force-pushed
the
a11y-nav
branch
from
7f74d01 to
ecdca2c
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng on links