build: include typings/index in root metadata export #7190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
reviewed
Sep 20, 2017
| @@ -65,7 +65,7 @@ export function composeRelease(buildPackage: BuildPackage) { | |||
| // re-exports everything. | |||
| createMetadataReexportFile( | |||
| releasePath, | |||
| buildPackage.secondaryEntryPoints.map(p => `./${p}`), | |||
| buildPackage.secondaryEntryPoints.concat(['typings/index']).map(p => `./${p}`), | |||
There was a problem hiding this comment.
Isn't that already handled a few lines above?
There was a problem hiding this comment.
This call to createMetadataReexportFile overwrites the file generated by the earlier call
There was a problem hiding this comment.
Okay that makes sense. I wonder if it would be more obvious if we place the earlier call in the else clause.
devversion
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fix our current issue (angular/angular#18752), but it should be included anyway.