Skip to content

chore: add stepper to prerender check #7225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2017
Merged

chore: add stepper to prerender check #7225

merged 1 commit into from
Oct 3, 2017

Conversation

devversion
Copy link
Member

  • Now validates that the stepper component can be pre-rendered inside of the server platform.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 21, 2017
jelbourn
jelbourn approved these changes Sep 21, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 21, 2017
@jelbourn
Copy link
Member

@devversion needs rebase

@devversion devversion force-pushed the chore/add-stepper-to-prerender-check branch from c8aa422 to dcaae69 Compare September 29, 2017 11:31
@andrewseguin
Copy link
Contributor

Needs rebase =D

@andrewseguin andrewseguin added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Sep 29, 2017
@devversion
chore: add stepper to prerender check
dad2c61 
* Now validates that the stepper component can be pre-rendered inside of the server platform.
@devversion devversion force-pushed the chore/add-stepper-to-prerender-check branch from dcaae69 to dad2c61 Compare September 30, 2017 07:55
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Sep 30, 2017
@kara kara merged commit 199056c into angular:master Oct 3, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @jelbourn @andrewseguin @kara @googlebot