Skip to content

chore: better color usage for chip demo #7254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2017
Merged

chore: better color usage for chip demo #7254

merged 1 commit into from
Sep 29, 2017

Conversation

devversion
Copy link
Member

  • Improves the example for the chips that shows how the color can be set for chips.
  • Fixes a typo in the chips readme

References #7243

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 22, 2017
tinayuangao
tinayuangao approved these changes Sep 25, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 25, 2017
jelbourn
jelbourn approved these changes Sep 26, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

@devversion needs rebase

@devversion
chore: better color usage for chip demo
a105dd2 
* Improves the example for the chips that shows how the color can be set for chips.
* Fixes a typo in the chips readme

References angular#7243
@devversion devversion force-pushed the chore/fix-chips-color branch from 5020408 to a105dd2 Compare September 29, 2017 10:56
@andrewseguin andrewseguin merged commit d858ad9 into angular:master Sep 29, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@tinayuangao tinayuangao tinayuangao approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @jelbourn @tinayuangao @googlebot @andrewseguin