Skip to content

fix(progress-spinner): default strokeWidth to 10% of the diameter #7746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2017
Merged

fix(progress-spinner): default strokeWidth to 10% of the diameter #7746

merged 1 commit into from
Nov 7, 2017

Conversation

crisbeto
Copy link
Member

Currently the default stroke of a spinner is always 10px which doesn't look great on anything that's smaller than the default. These changes switch it to be 10% of the circle's diameter.

Fixes #7708.

@crisbeto
fix(progress-spinner): default strokeWidth to 10% of the diameter
e80295f 
Currently the default stroke of a spinner is always 10px which doesn't look great on anything that's smaller than the default. These changes switch it to be 10% of the circle's diameter.

Fixes angular#7708.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 12, 2017
@jelbourn jelbourn requested a review from kara October 12, 2017 18:55
josephperrott
josephperrott approved these changes Oct 12, 2017
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kara
kara approved these changes Oct 12, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 12, 2017
@kara
Copy link
Contributor

kara commented Oct 12, 2017

Caretaker note: Please use extra care when presubmitting, due to recent spinner issues.

CSS: @jelbourn

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 12, 2017
@josephperrott josephperrott merged commit b997353 into angular:master Nov 7, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[spinner] default strokeWidth to 1/10th diameter
4 participants
@crisbeto @kara @josephperrott @googlebot