chore(ripple): no longer update if _matRippleTrigger changes
#7903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
Oct 19, 2017
| @@ -100,7 +100,7 @@ export class MatRipple implements OnChanges, OnDestroy { | |||
| } | |||
|
|
|||
| ngOnChanges(changes: SimpleChanges) { | |||
| if ((changes['trigger'] || changes['_matRippleTrigger']) && this.trigger) { | |||
| if (changes['trigger'] && this.trigger) { | |||
There was a problem hiding this comment.
You should be able to switch this to change.trigger as well.
There was a problem hiding this comment.
Done. As @jelbourn mentioned, the trigger needs to be a string to avoid closure renaming.
andrewseguin
added
pr: lgtm
action: merge
jelbourn
reviewed
Oct 24, 2017
src/lib/core/ripple/ripple.ts
Outdated
| @@ -100,7 +100,7 @@ export class MatRipple implements OnChanges, OnDestroy { | |||
| } | |||
|
|
|||
| ngOnChanges(changes: SimpleChanges) { | |||
| if ((changes['trigger'] || changes['_matRippleTrigger']) && this.trigger) { | |||
| if (changes.trigger && this.trigger) { | |||
There was a problem hiding this comment.
trigger needs to stay as a string or else Closure Compiler might rename it (which we don't want for input names)
There was a problem hiding this comment.
Makes sense. Changed it back to be on the safe side.
* Since the `md-` prefix is now removed completely, the `_matRippleTrigger` property is just `trigger` now.
devversion
force-pushed
the
chore/ripple-remove-prefix-check
branch
from
5e08768 to
f9c820a
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md-prefix is now removed completely, the_matRippleTriggerproperty is justtriggernow.