Skip to content

fix(select): make @Output names consistent #6677 #8052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/select/select.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3390,7 +3390,7 @@ class NgIfSelect {
selector: 'select-with-change-event',
template: `
<mat-form-field>
<mat-select (change)="changeListener($event)">
<mat-select (selectionChange)="changeListener($event)">
<mat-option *ngFor="let food of foods" [value]="food">{{ food }}</mat-option>
</mat-select>
</mat-form-field>
Expand Down
45 changes: 36 additions & 9 deletions src/lib/select/select.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
ScrollStrategy,
ViewportRuler,
} from '@angular/cdk/overlay';
import {filter, first, startWith, takeUntil} from 'rxjs/operators';
import {filter, first, map, startWith, takeUntil} from 'rxjs/operators';
import {
AfterContentInit,
Attribute,
Expand Down Expand Up @@ -401,14 +401,41 @@ export class MatSelect extends _MatSelectMixinBase implements AfterContentInit,
return merge(...this.options.map(option => option.onSelectionChange));
}

/** Event emitted when the select has been opened. */
@Output() onOpen: EventEmitter<void> = new EventEmitter<void>();
/** Event emitted when the select has been opened. */
@Output() openedChange: EventEmitter<boolean> = new EventEmitter<boolean>();

/** Event emitted when the select has been opened. */
@Output('opened')
get _openedStream(): Observable<void> {
return this.openedChange.pipe(filter(o => o), map(() => {}));
}

/** Event emitted when the select has been closed. */
@Output() onClose: EventEmitter<void> = new EventEmitter<void>();
@Output('closed')
get _closedStream(): Observable<void> {
return this.openedChange.pipe(filter(o => !o), map(() => {}));
}

/**
* Event emitted when the select has been opened.
* @deprecated Use `openedChange` instead.
*/
@Output() onOpen: Observable<void> = this._openedStream;

/** Event emitted when the selected value has been changed by the user. */
@Output() change: EventEmitter<MatSelectChange> = new EventEmitter<MatSelectChange>();
/**
* Event emitted when the select has been closed.
* @deprecated Use `openedChange` instead.
*/
@Output() onClose: Observable<void> = this._closedStream;

/** Event emitted when the selected value has been changed by the user. */
@Output() selectionChange: EventEmitter<MatSelectChange> = new EventEmitter<MatSelectChange>();

/**
* Event emitted when the selected value has been changed by the user.
* @deprecated Use `selectionChange` instead.
*/
@Output() change: EventEmitter<MatSelectChange> = this.selectionChange;

/**
* Event that emits whenever the raw value of the select changes. This is here primarily
Expand Down Expand Up @@ -637,9 +664,9 @@ export class MatSelect extends _MatSelectMixinBase implements AfterContentInit,
_onPanelDone(): void {
if (this.panelOpen) {
this._scrollTop = 0;
this.onOpen.emit();
this.openedChange.emit(true);
} else {
this.onClose.emit();
this.openedChange.emit(false);
this._panelDoneAnimating = false;
this.overlayDir.offsetX = 0;
this._changeDetectorRef.markForCheck();
Expand Down Expand Up @@ -859,7 +886,7 @@ export class MatSelect extends _MatSelectMixinBase implements AfterContentInit,

this._value = valueToEmit;
this._onChange(valueToEmit);
this.change.emit(new MatSelectChange(this, valueToEmit));
this.selectionChange.emit(new MatSelectChange(this, valueToEmit));
this.valueChange.emit(valueToEmit);
this._changeDetectorRef.markForCheck();
}
Expand Down