Skip to content

fix(select): error when attempting to open before init #8242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 6, 2017

Fixes an error that could be thrown by mat-select if it is opened before everything is done initializing.

Fixes #8236.

@crisbeto crisbeto requested a review from kara as a code owner November 6, 2017 06:52
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 6, 2017
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 6, 2017
@josephperrott
Copy link
Member

Please rebase

Fixes an error that could be thrown by `mat-select` if it is opened before everything is done initializing.

Fixes angular#8236.
@crisbeto crisbeto force-pushed the 8236/select-open-early branch from 55b1b0d to 1afb2ba Compare November 8, 2017 12:30
@crisbeto
Copy link
Member Author

crisbeto commented Nov 8, 2017

Rebased @josephperrott.

@josephperrott josephperrott merged commit ba36d3a into angular:master Nov 10, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'isEmpty' of undefined
4 participants