Skip to content

fix(tabs): hidden tabs don't render expansion panels correctly #8825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(tabs): hidden tabs don't render expansion panels correctly #8825

wants to merge 2 commits into from

Conversation

tiaguinho
Copy link
Contributor

Fix issue #5269

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a test to verify this is fixing the issue as described?

I don't believe this will fix the issue as expected as immediate attachment of the tabs content does not cause the animations to run as expected so the expansion panels will still look incorrect.

@josephperrott josephperrott self-assigned this Dec 5, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 5, 2017
@tiaguinho
Copy link
Contributor Author

tiaguinho commented Dec 5, 2017

@josephperrott I just add the test to demo app.

@josephperrott
Copy link
Member

In looking closer at this change, we actually can't do this change as it is a major change to the workings of material tabs. This change immediately attaches all of the tab bodies to the DOM, which places more items in the DOM that are needed.

@tiaguinho
Copy link
Contributor Author

When I made the change, I see this problem too. This probably will reduce tabs performance because all the bodies are attached to the DOM.
But fixing the bug isn't better than have performance with a bug?
This can't be a workaround until we find a better solution?

@josephperrott
Copy link
Member

We determined that it is more valuable to not change the functionality back and forth between the two concepts. Also in the near future we should be able to land #6832 which also could be used as a workaround.

@tiaguinho
Copy link
Contributor Author

Ok.
Thank you.

@tiaguinho tiaguinho closed this Dec 6, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants