Skip to content

chore: missing type for parameter in autosize #8906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Dec 9, 2017

  • The MatTextareaAutosize directive misses a type for the resizeToFitContent method. The gulp api-docs task showed that the type is missing.
  • Improves the normalizeMethodParameters method in the Dgeni setup, to also add type information to parameters that have been parsed properly by Dgeni, but still miss a type.

* The ``MatTextareaAutosize` directive misses a type for the `resizeToFitContent` method. The `gulp api-docs` task showed that the type is missing.
* Improves the `normalizeMethodParameters` method in the Dgeni setup, to also add type information to parameters that have been parsed properly by Dgeni, but still miss a type.
@devversion devversion added pr: needs review target: patch This PR is targeted for the next patch release labels Dec 9, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 9, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 12, 2017
@andrewseguin andrewseguin merged commit f5a2faf into angular:master Dec 14, 2017
andrewseguin pushed a commit that referenced this pull request Dec 19, 2017
* The ``MatTextareaAutosize` directive misses a type for the `resizeToFitContent` method. The `gulp api-docs` task showed that the type is missing.
* Improves the `normalizeMethodParameters` method in the Dgeni setup, to also add type information to parameters that have been parsed properly by Dgeni, but still miss a type.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants